[IMPROVE] New emails design #12009

ggazzo · 2018-09-10T17:17:35Z

ps: its not done yet (even the prints) ;)

welcome screen

confirm email

forgot password

mail messages

invitation email

engelgabriel · 2018-09-13T00:33:01Z

packages/rocketchat-mailer/package.js

 	]);
+	Npm.depends({


@ggazzo we are trying to keep the NPM dependencies on the root package.json file

@rodrigok can you help here?

engelgabriel · 2018-09-13T00:34:27Z

packages/rocketchat-i18n/i18n/en.i18n.json

@@ -555,6 +553,7 @@
  "Compact": "Compact",
  "Condensed": "Condensed",
  "Computer": "Computer",
+


remove empty line

engelgabriel · 2018-09-13T00:35:05Z

packages/rocketchat-i18n/i18n/en.i18n.json

@@ -1220,6 +1219,7 @@
  "Force_SSL": "Force SSL",
  "Force_SSL_Description": "*Caution!* _Force SSL_ should never be used with reverse proxy. If you have a reverse proxy, you should do the redirect THERE. This option exists for deployments like Heroku, that does not allow the redirect configuration at the reverse proxy.",
  "Forgot_password": "Forgot your password",
+  "Forgot_password_ask": "Forgot your password?",


Please don't add a new key, use the one above.

engelgabriel · 2018-09-13T00:35:49Z

packages/rocketchat-i18n/i18n/en.i18n.json

@@ -1663,6 +1664,7 @@
  "Log_View_Limit": "Log View Limit",
  "Logged_out_of_other_clients_successfully": "Logged out of other clients successfully",
  "Login": "Login",
+  "Login_now": "Login now",


Please don't add a new key, use the one above.

engelgabriel · 2018-09-13T00:35:57Z

packages/rocketchat-i18n/i18n/en.i18n.json

@@ -2146,6 +2148,7 @@
  "Require_password_change": "Require password change",
  "Resend_verification_email": "Resend verification email",
  "Reset": "Reset",
+  "Reset_now": "Reset now",


Please don't add a new key, use the one above.

@thiagosanchz what do you think about change that texts(remove the now)? I really like the now words :/

@engelgabriel @ggazzo Why we can't add new words? I think the word NOW emphasizes the action.

@thiagosanchz @ggazzo @brunosquadros @sampaiodiego let's not create new translation keys like this, that are important and don't add much to the user experience. Every new KEY will have to be translated into 50 languages and maintained. We already have far more keys that we need and we have a big mess because of it. We are trying to reduce the number of redundant translation keys.

engelgabriel · 2018-09-13T00:38:45Z

packages/rocketchat-lib/server/functions/saveUser.js

+	setTimeout(() => {
+		RocketChat.settings.get('Accounts_UserAddedEmail', (key, value) => {
+			body = inlinecss(value);
+			console.log(body);


is this for debug?

mnlbox · 2018-09-13T05:41:53Z

@ggazzo Is it OK in RTL mode?

…email-templates

engelgabriel · 2018-09-17T20:58:04Z

packages/rocketchat-channel-settings-mail-messages/server/methods/mailMessages.js

@@ -1,9 +1,11 @@
 import _ from 'underscore';
 import moment from 'moment';
+import { send as sendEmail, checkEmail } from 'meteor/rocketchat:mailer';


Let's nos use "as sendEmail" and keep the names the same everywhere for clarity.

sampaiodiego

with latest changes:

I've ended with multiple settings for:
- Invitation
- Registration via Admin

Like this:

geekgonecrazy · 2018-09-27T03:18:30Z

packages/rocketchat-i18n/i18n/en.i18n.json

@@ -1346,6 +1346,7 @@
  "If_you_are_sure_type_in_your_password": "If you are sure type in your password:",
  "If_you_are_sure_type_in_your_username": "If you are sure type in your username:",
  "If_you_dont_have_one_send_an_email_to_omni_rocketchat_to_get_yours": "If you don't have one send an email to [omni@rocket.chat](mailto:omni@rocket.chat) to get yours.",
+  "If_you_didnt_ask_for_reset_ignore_this_email" : "If you didn't ask for reset your password, don't worry, just ignore this email",


If you didn't ask for your password reset, don't worry, just ignore this email

would be more proper placement of reset.

If you didn't ask for your password reset, you can ignore this email.

But to me this would be better 🔝

I still don't think we should say to ignore 😛 it might indicate a tentative of account steal.

geekgonecrazy · 2018-09-27T03:39:20Z

packages/rocketchat-i18n/i18n/en.i18n.json

@@ -2780,13 +2780,14 @@
  "UTF8_Names_Validation": "UTF8 Names Validation",
  "UTF8_Names_Validation_Description": "RegExp that will be used to validate usernames and channel names",
  "Validate_email_address": "Validate Email Address",
+  "Verification_email_body": "You have succesfully created an account on [Site_Name]. Please, click on the button bellow to confirm your email address and finish your registration",


bellow -> below

and i'd change:

to confirm your email address and finish your registration

to

to confirm your email address and finish registration

bellow -> below

🤦‍♂️ I was so confident it was bellow

😁 to Bellow is to yell or roar but in a deep voice

…at into new-email-templates

fixed

first commit

7ed0b89

engelgabriel had a problem deploying to rocket-chat-pr-12009 September 10, 2018 17:17 Failure

engelgabriel temporarily deployed to rocket-chat-pr-12009 September 10, 2018 20:41 Inactive

ggazzo requested review from tassoevan and sampaiodiego September 10, 2018 20:42

ggazzo added the ui/ux label Sep 10, 2018

ggazzo added this to the 0.70.0 milestone Sep 10, 2018

ggazzo force-pushed the new-email-templates branch from 940726e to cb5fadc Compare September 10, 2018 21:09

ggazzo temporarily deployed to rocket-chat-pr-12009 September 10, 2018 21:09 Inactive

improved the mostly used emails

106fd61

ggazzo force-pushed the new-email-templates branch from cb5fadc to 106fd61 Compare September 10, 2018 21:14

ggazzo temporarily deployed to rocket-chat-pr-12009 September 10, 2018 21:14 Inactive

RocketChat deleted a comment Sep 10, 2018

sampaiodiego mentioned this pull request Sep 11, 2018

[FIX] Incorrect use of RocketChat.placeholders #12012

Closed

engelgabriel previously requested changes Sep 13, 2018

View reviewed changes

ggazzo requested a review from thiagosanchz September 17, 2018 14:35

Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new-…

6fbd9e0

…email-templates

engelgabriel reviewed Sep 17, 2018

View reviewed changes

improve name functions

6624162

ggazzo temporarily deployed to rocket-chat-pr-12009 September 18, 2018 16:24 Inactive

Merge branch 'develop' into new-email-templates

0ffb639

ggazzo temporarily deployed to rocket-chat-pr-12009 September 18, 2018 16:37 Inactive

Fix translations

1136f41

sampaiodiego temporarily deployed to rocket-chat-pr-12009 September 27, 2018 01:30 Inactive

sampaiodiego requested changes Sep 27, 2018

View reviewed changes

geekgonecrazy previously requested changes Sep 27, 2018

View reviewed changes

Fix test

25d1e59

sampaiodiego temporarily deployed to rocket-chat-pr-12009 September 27, 2018 12:14 Inactive

renamed some setting during migration

b611f69

ggazzo temporarily deployed to rocket-chat-pr-12009 September 27, 2018 16:12 Inactive

Merge branch 'new-email-templates' of github.com:RocketChat/Rocket.Ch…

0bafc82

…at into new-email-templates

ggazzo force-pushed the new-email-templates branch from 1c761fe to 0bafc82 Compare September 27, 2018 16:13

ggazzo temporarily deployed to rocket-chat-pr-12009 September 27, 2018 16:14 Inactive

fix migration, ops

4bc4e7f

ggazzo temporarily deployed to rocket-chat-pr-12009 September 27, 2018 19:33 Inactive

Fix migration again v2

6341d27

sampaiodiego deployed to rocket-chat-pr-12009 September 27, 2018 20:17 View deployment

sampaiodiego approved these changes Sep 27, 2018

View reviewed changes

vynmera approved these changes Sep 27, 2018

View reviewed changes

sampaiodiego changed the title ~~[BREAK][IMPROVE] new email design~~ [BREAK][IMPROVE] New emails design Sep 28, 2018

sampaiodiego merged commit 335d9d8 into develop Sep 28, 2018

sampaiodiego deleted the new-email-templates branch September 28, 2018 00:18

This was referenced Sep 28, 2018

Release 0.70.0 #12197

Closed

Release 0.70.0 #12198

Merged

geekgonecrazy mentioned this pull request Sep 28, 2018

After update to 0.70.0 Rocket.Chat dont start #12212

Closed

rodrigok changed the title ~~[BREAK][IMPROVE] New emails design~~ [BREAK] Improve emails design Oct 5, 2018

rodrigok changed the title ~~[BREAK] Improve emails design~~ [IMPROVE] New emails design Oct 5, 2018

ggazzo mentioned this pull request Oct 19, 2018

new line (\n) does not work in password reset email #4001

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMPROVE] New emails design #12009

[IMPROVE] New emails design #12009

ggazzo commented Sep 10, 2018 •

edited

Loading

engelgabriel Sep 13, 2018

engelgabriel Sep 13, 2018

engelgabriel Sep 13, 2018

engelgabriel Sep 13, 2018

engelgabriel Sep 13, 2018

ggazzo Sep 17, 2018

thiagosanchz Sep 17, 2018

engelgabriel Sep 17, 2018

engelgabriel Sep 13, 2018

mnlbox commented Sep 13, 2018

engelgabriel Sep 17, 2018

sampaiodiego left a comment

geekgonecrazy Sep 27, 2018

sampaiodiego Sep 27, 2018

geekgonecrazy Sep 27, 2018 •

edited

Loading

sampaiodiego Sep 27, 2018

geekgonecrazy Sep 27, 2018

[IMPROVE] New emails design #12009

[IMPROVE] New emails design #12009

Conversation

ggazzo commented Sep 10, 2018 • edited Loading

welcome screen

confirm email

forgot password

mail messages

invitation email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mnlbox commented Sep 13, 2018

Choose a reason for hiding this comment

sampaiodiego left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

geekgonecrazy Sep 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ggazzo commented Sep 10, 2018 •

edited

Loading

geekgonecrazy Sep 27, 2018 •

edited

Loading